Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sprite and picking examples #15803

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

Jondolf
Copy link
Contributor

@Jondolf Jondolf commented Oct 9, 2024

Objective

Looks like #15489 broke some examples :) And there are some other issues as well.

Gabe's brother Gabe is tiny in the sprite_animation example:

kuva

Gabe is not running in the sprite_picking example, and (unrelated) is also very blurry: (note that the screenshot is a bit zoomed in)

kuva

Unrelated to sprites, the text in the simple_picking example is way too dark when hovered:

kuva

Solution

Both Gabes are now the correct size:

kuva

Gabe is crisp and running:

kuva

The text has better contrast:

kuva

@Jondolf Jondolf added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels Oct 9, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 9, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 9, 2024
Merged via the queue into bevyengine:main with commit bd0c746 Oct 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Picking Pointing at and selecting objects of all sorts A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants