[Merged by Bors] - Update glam to 0.13.0.

[bitshifter]

See https://github.com/bitshifter/glam-rs/blob/master/CHANGELOG.md for details on changes.

[Ratysz]

Don't forget to cargo fmt.

[Ratysz]

Looks like there were more deprecations in this update:

error: use of deprecated associated function `bevy_math::Mat4::identity`: use Mat4::IDENTITY instead
   --> crates/bevy_core/src/bytes.rs:234:25
    |
234 |         test_round_trip(Mat4::identity());
    |                         ^^^^^^^^^^^^^^
    |
    = note: `-D deprecated` implied by `-D warnings`

[mockersf]

What do you think of replacing VecN::default() with VecN::ZERO to benefit there also from the new consts? As a plus I find it clearer when reading the code to know directly what the vec used is instead of remembering "default is zero for vec"

[bitshifter]

@mockersf I agree, I think VecN::ZERO would be a bit clearer intent wise than VecN::default(). Other than that, it might remove a function call in unoptimised builds but I think it's probably much of a muchness otherwise.

[Ratysz]

Please resolve warnings locally first?

[bitshifter]

@Ratysz I did build locally but I did not see these warnings. They appear to be from iOS examples, perhaps they aren't part of the standard build?

[Ratysz]

The one I linked runs cargo clippy --workspace --all-targets --all-features -- -D warnings -A clippy::type_complexity -A clippy::manual-strip on Linux, and the warning comes from an example.

[bitshifter]

Does that require nightly? failed to build for me at all on Rust stable 1.50 on Windows:

error: use of a blacklisted/placeholder name `foo`
   --> crates\bevy_tasks\src\task_pool.rs:283:13
    |
283 |         let foo = Box::new(42);
    |             ^^^
    |
    = note: `-D clippy::blacklisted-name` implied by `-D warnings`

etc.

[bitshifter]

The file that is failing now was added at some point after I made this PR, which is why I didn't see it. I need to rebase with main.

[Ratysz]

That's odd. I know this sounds silly, but it works on my machine 😄

[bitshifter]

It worked after rebasing.

[alec-deason]

I'm excited to see this one land.

[cart]

Thanks for keeping us up to date! Looks good to me.

[cart]

We will need to update hexasphere before merging to avoid duplicate deps: https://github.com/OptimisticPeach/hexasphere
@OptimisticPeach down to do an update?

[OptimisticPeach]

Of course! I'll have it ready in an hour or so.

[OptimisticPeach]

Half an hour, actually, hexasphere 3.2.0 is up.

Related: how would you feel if I were to rewrite/refactor hexasphere to be generic over the vector used in a separate crate (and then use that in bevy), so updating glam is seamless?

[cart]

That sounds good to me!

[cart]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-android
• build (nightly, ubuntu-latest)
• build (stable, macos-latest)
• build (stable, ubuntu-latest)
• build (stable, windows-latest)
• build-wasm (nightly, ubuntu-latest)
• build-wasm (stable, ubuntu-latest)
• markdownlint