Reduce memory usage in component fetches and change detection filters #15283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: james7132 <[email protected]>
ItsDoot
added
A-ECS
Full ECS benchmark suite results (this PR on left) |
|
Code changes seem reasonable, but those benchmark results are super weird. Why would only some of the busy_systems benchmarks have a 40%+ slowdown? Can you rerun them and post the results? |
|
@alice-i-cecile Reran on a different machine: Full ECS suite benchmarks (this PR on left) |
|
Okay, thanks :) I'm happy to call the benchmarks largely noise. Reducing memory usage has its own value though, so I'm in favor. |
|
It might be nice to add some convenience methods to pub fn new(table: impl FnOnce() -> T, sparse_set: impl FnOnce() -> S) -> Self {
match C::STORAGE_TYPE {
StorageType::Table => Self {
table: ManuallyDrop::new(table()),
},
StorageType::SparseSet => Self {
sparse_set: ManuallyDrop::new(sparse_set()),
},
}
}
pub fn extract<R>(&self, table: impl FnOnce(T) -> R, sparse_set: impl FnOnce(S) -> R) -> R {
match C::STORAGE_TYPE {
StorageType::Table => table(unsafe { *self.table }),
StorageType::SparseSet => sparse_set(unsafe { *self.sparse_set }),
}
} |
chescock
approved these changes
Sep 21, 2024
Co-authored-by: Chris Russell <[email protected]>
💯 Very good idea, that works out much better. |
chescock
approved these changes
Sep 27, 2024
alice-i-cecile
approved these changes
Sep 27, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
…bevyengine#15283) ## Objective - Adopted bevyengine#6396 ## Solution Same as bevyengine#6396, we use a compile-time checked `StorageSwitch` union type to select the fetch data based on the component's storage type, saving >= 8 bytes per component fetch in a given query. Note: We forego the Query iteration change as it exists in a slightly different form now on main. ## Testing - All current tests pass locally. --------- Co-authored-by: james7132 <[email protected]> Co-authored-by: Chris Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Same as #6396, we use a compile-time checked
StorageSwitchunion type to select the fetch data based on the component's storage type, saving >= 8 bytes per component fetch in a given query.Note: We forego the Query iteration change as it exists in a slightly different form now on main.
Testing