Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dev docs robots.txt containing a literal \n instead of a newline #14347

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix the dev docs robots.txt containing a literal \n instead of a newline #14347

merged 1 commit into from
Jul 16, 2024

Conversation

Brezak
Copy link
Contributor

@Brezak Brezak commented Jul 16, 2024 •
edited
Loading

Objective

The robots.txt file for the dev docs looks like this User-Agent: *\nDisallow: /
It should look like this

User-Agent: *
Disallow: /

Solution

Use ANSI-C quoting to properly handle the \n

Testing

  • Run the fixed echo command in local terminal.
  • Wait for the dev doces to deploy and observe if the mistake has been fixed

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 16, 2024
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Build-System Related to build systems or continuous integration labels Jul 16, 2024
@alice-i-cecile alice-i-cecile removed this pull request from the merge queue due to a manual request Jul 16, 2024
@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 16, 2024
@mockersf mockersf added this pull request to the merge queue Jul 16, 2024
Merged via the queue into bevyengine:main with commit 293e915 Jul 16, 2024
33 checks passed
@Brezak Brezak deleted the dev-docs-robots branch July 17, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brezak @alice-i-cecile @mockersf