Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QueryState::contains, document complexity, and make as_nop pub(crate) #12776

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Add QueryState::contains, document complexity, and make as_nop pub(crate) #12776

merged 2 commits into from
Mar 29, 2024

Conversation

james7132
Copy link
Member

Objective

Fixes #12752. Fixes #12750. Document the runtime complexity of all of the O(1) operations on the individual APIs.

Solution

  • Mirror Query::contains onto QueryState::contains
  • Make QueryState::as_nop pub(crate)
  • Make NopWorldQuery pub(crate)
  • Document all of the O(1) operations on Query and QueryState.

@james7132 james7132 added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Mar 29, 2024
@james7132 james7132 requested a review from ItsDoot March 29, 2024 06:57
@james7132 james7132 added this pull request to the merge queue Mar 29, 2024
Merged via the queue into bevyengine:main with commit a6e37e7 Mar 29, 2024
27 checks passed
@ChristopherBiscardi ChristopherBiscardi mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@ItsDoot ItsDoot Awaiting requested review from ItsDoot

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make QueryState::as_nop pub(crate) Add QueryState::contains to mirror Query::contains
2 participants
@james7132 @alice-i-cecile