Added reflect support for std::HashSet, BTreeSet and BTreeMap. #12124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Feb 26, 2024
soqb
approved these changes
Feb 26, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
SkiFire13
reviewed
Feb 26, 2024
| @@ -620,6 +622,220 @@ impl_type_path!(::bevy_utils::hashbrown::hash_map::DefaultHashBuilder); | |||
| impl_type_path!(::bevy_utils::NoOpHash); | |||
| impl_type_path!(::bevy_utils::hashbrown::HashMap<K, V, S>); | |||
|
|
|||
| macro_rules! impl_reflect_for_btree_map { | |||
There was a problem hiding this comment.
Was this macro really necessary? It's not like it will be used more than once, and it makes source navigation harder.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…ngine#12124) # Objective Added reflect support for `std::HashSet`, `BTreeSet` and `BTreeMap`. The set support is limited to `reflect_value` since that's the level of support prior art `bevy_util::HashSet` got. ## Changelog Dropped `Hash` Requirement on `MapInfo` since it's not needed on `BTreeMap`s.
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…ngine#12124) # Objective Added reflect support for `std::HashSet`, `BTreeSet` and `BTreeMap`. The set support is limited to `reflect_value` since that's the level of support prior art `bevy_util::HashSet` got. ## Changelog Dropped `Hash` Requirement on `MapInfo` since it's not needed on `BTreeMap`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Added reflect support for
std::HashSet,BTreeSetandBTreeMap.The set support is limited to
reflect_valuesince that's the level of support prior artbevy_util::HashSetgot.Changelog
Dropped
HashRequirement onMapInfosince it's not needed onBTreeMaps.