fix some typos #12038
Merged
fix some typos #12038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 22, 2024
alice-i-cecile
added
the
C-Code-Quality
james7132
added
the
M-Needs-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
james7132
requested changes
Feb 22, 2024
mockersf
requested changes
Feb 22, 2024
There was a problem hiding this comment.
file names in assets/texture/rpg/ui are not a typo, they are the actual file names that the author used, see https://bakudas.itch.io/generic-rpg-pack
mockersf
reviewed
Feb 22, 2024
mockersf
reviewed
Feb 22, 2024
Co-authored-by: James Liu <[email protected]>
Co-authored-by: François <[email protected]>
Co-authored-by: François <[email protected]>
ameknite
force-pushed
the
fix-some-typos
branch
from
41e08aa to
fe0d05f
Compare
mockersf
approved these changes
Feb 22, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective Split - containing only the fixed typos - bevyengine#12036 (review) # Migration Guide In `crates/bevy_mikktspace/src/generated.rs` ```rs // before pub struct SGroup { pub iVertexRepresentitive: i32, .. } // after pub struct SGroup { pub iVertexRepresentative: i32, .. } ``` In `crates/bevy_core_pipeline/src/core_2d/mod.rs` ```rs // before Node2D::ConstrastAdaptiveSharpening // after Node2D::ContrastAdaptiveSharpening ``` --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: James Liu <[email protected]> Co-authored-by: François <[email protected]>
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
# Objective Split - containing only the fixed typos - bevyengine#12036 (review) # Migration Guide In `crates/bevy_mikktspace/src/generated.rs` ```rs // before pub struct SGroup { pub iVertexRepresentitive: i32, .. } // after pub struct SGroup { pub iVertexRepresentative: i32, .. } ``` In `crates/bevy_core_pipeline/src/core_2d/mod.rs` ```rs // before Node2D::ConstrastAdaptiveSharpening // after Node2D::ContrastAdaptiveSharpening ``` --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: James Liu <[email protected]> Co-authored-by: François <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Split - containing only the fixed typos
typos- Source code spell checker #12036 (review)Migration Guide
In
crates/bevy_mikktspace/src/generated.rsIn
crates/bevy_core_pipeline/src/core_2d/mod.rs