Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand requirement from 0.7 to 0.8 #1114

Merged
merged 2 commits into from
Jan 17, 2021
Merged

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Dec 21, 2020

(no, I don't know why dependabot missed this one. Yes I'm using their PR format.)

Updates the requirements on rand to permit the latest version.

Changelog

Sourced from rand's changelog.

[0.8.0] - 2020-12-18

Platform support

Rngs

Sequences

Misc

Distributions

Weighted sampling

Documentation

Commits visible in compare view.


Closes #1113.

We shouldn't merge this until uuid upgrades rand, to avoid pulling in two versions of rand.

@memoryruins memoryruins added dependencies C-Dependencies A change to the crates that Bevy depends on labels Dec 22, 2020
@cart
Copy link
Member

cart commented Dec 24, 2020

I dig this, but we should hold off on merging until downstream dependencies like uuid move off of the old rand version, otherwise we'll fracture deps / compile multiple versions:

uuid-rs/uuid#504

@CAD97
Copy link
Contributor Author

CAD97 commented Dec 25, 2020

Yep. (If you dig a little bit, I kicked off the movement to get the uuid update published.) Uuid is the only dep pulling in rand:0.7 once bevy internal crates update, and the uuid update should be published "soon".

@cart
Copy link
Member

cart commented Jan 1, 2021

Thanks for getting the ball rolling 😄

@CAD97
Copy link
Contributor Author

CAD97 commented Jan 16, 2021

uuid 0.8.2 with just the getrandom requirement has been published. Rebased; this should be good to merge.

cargo tree --duplicates after this change (and a cargo update) shows cfg-if as the only crate duplicated in-tree.

@cart cart merged commit 4d5ba79 into bevyengine:master Jan 17, 2021
rparrett pushed a commit to rparrett/bevy that referenced this pull request Jan 27, 2021
* Update rand requirement from 0.7 to 0.8

* Update examples' usage of Rng::gen_range
@CAD97 CAD97 deleted the upgrade-rand branch March 11, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to rand:0.8.0
3 participants