-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nightly to have scraping examples for dev-docs generation #10130
Enable nightly to have scraping examples for dev-docs generation #10130
Conversation
This is not for docs.rs, this is for https://dev-docs.bevyengine.org/bevy/index.html docs.rs issue is related to rust-lang/docs.rs#2305 |
This is a tentative solution, I'm not familiar enough with github workflows... I have seen some of the issues on the subject, and the PR merged (for 0.11.1 I believe), everything looks fine. Hope I'm not stepping on anyone's toes here. If I am feel free to close this PR. |
@mockersf Ah I didn't go deep enough it seems... Sorry about that... Closing this PR. |
In my opinion it's still interesting to enable scraping examples on the dev-docs, so this PR makes sense! |
521a3db
to
c5750ad
Compare
Enabling nightly should be enough then, and whatever needs to be done as well for docs.rs. |
#2305 was merged, so this is now mergeable! |
c5750ad
to
b1eabb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs to be changed to @nightly
, or the CI will fail. See docs on action.
bevy/.github/workflows/docs.yml
Lines 36 to 37 in b6e154f
- name: Install Rust | |
uses: dtolnay/rust-toolchain@stable |
Edit: This may also let you remove the +nightly
modifier, since it will be the only toolchain installed.
b1eabb5
to
0988bb3
Compare
@BD103 All done! Thanks! |
done in #12223, sorry I forgot about this PR |
Objective
Solution
rustdoc-scrape-examples
flag seems to work better than setting in the Cargo.toml.