-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register missing types for Camera
#6169
Comments
I cant comment on the idea, however I implemented it if it is a good idea 🤷 |
I registered these types in https://github.com/bevyengine/bevy/pull/6061/files, so with that just |
You’re saying to register it in |
…ore functionality. (bevyengine#6170) … # Objective - Fixes Camera not being serializable due to missing registrations in core functionality. - Fixes bevyengine#6169 ## Solution - Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169 Co-authored-by: Noah <[email protected]>
…ore functionality. (bevyengine#6170) … # Objective - Fixes Camera not being serializable due to missing registrations in core functionality. - Fixes bevyengine#6169 ## Solution - Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169 Co-authored-by: Noah <[email protected]>
…ore functionality. (bevyengine#6170) … # Objective - Fixes Camera not being serializable due to missing registrations in core functionality. - Fixes bevyengine#6169 ## Solution - Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169 Co-authored-by: Noah <[email protected]>
…ore functionality. (bevyengine#6170) … # Objective - Fixes Camera not being serializable due to missing registrations in core functionality. - Fixes bevyengine#6169 ## Solution - Updated Bevy_Render CameraPlugin with registrations for Option<Viewport> and then Bevy_Core CorePlugin with registrations for ReflectSerialize and ReflectDeserialize for type data Range<f32> respectively according to the solution in bevyengine#6169 Co-authored-by: Noah <[email protected]>
What problem does this solve or what need does it fill?
Camera
cannot be serialized via reflection due to some missing registrations:Option<Viewport>
ReflectSerialize
/ReflectDeserialize
type data forRange<f32>
What solution would you like?
bevy_render
'sCameraPlugin
should registerOption<Viewport>
.bevy_core
sCorePlugin
should register theReflectSerialize
andReflectDeserialize
type data forRange<f32>
What alternative(s) have you considered?
Users could manually implement these themselves. I don't think that's a good idea, though, as this should really be handled by Bevy since it directly uses those two types.
Additional context
🔗 Discord Help Thread
The text was updated successfully, but these errors were encountered: