Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Reflect impl for VecDeque #5791

Closed
ItsDoot opened this issue Aug 25, 2022 · 0 comments
Closed

Missing Reflect impl for VecDeque #5791

ItsDoot opened this issue Aug 25, 2022 · 0 comments
Labels
A-Reflection Runtime information about types C-Feature A new feature, making something new possible

Comments

@ItsDoot
Copy link
Contributor

ItsDoot commented Aug 25, 2022

What problem does this solve or what need does it fill?

It would be nice to be able to use a queue/stack like data structure in components; VecDeque fits that.

What solution would you like?

Implement the reflect family of traits for VecDeque.

What alternative(s) have you considered?

Using Vec, which is annoying to use as a queue.
@ItsDoot ItsDoot added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 25, 2022
@ItsDoot ItsDoot mentioned this issue Aug 25, 2022
Closed
@NathanSWard NathanSWard added A-Reflection Runtime information about types and removed S-Needs-Triage This issue needs to be labelled labels Aug 25, 2022
bors bot pushed a commit that referenced this issue Sep 7, 2022
@ItsDoot
Add reflection support for VecDeque (#5792)
b5d1d2a 
# Objective

Fixes #5791

## Solution

Implemented all the required reflection traits for `VecDeque`, taking from `Vec`'s impls.
bors bot pushed a commit that referenced this issue Sep 19, 2022
@ItsDoot
Add reflection support for VecDeque (#5792)
9472119 
# Objective

Fixes #5791

## Solution

Implemented all the required reflection traits for `VecDeque`, taking from `Vec`'s impls.
bors bot pushed a commit that referenced this issue Sep 19, 2022
@ItsDoot
Add reflection support for VecDeque (#5792)
5e34a53 
# Objective

Fixes #5791

## Solution

Implemented all the required reflection traits for `VecDeque`, taking from `Vec`'s impls.
bors bot pushed a commit that referenced this issue Sep 19, 2022
@ItsDoot
Add reflection support for VecDeque (#5792)
b95b650 
# Objective

Fixes #5791

## Solution

Implemented all the required reflection traits for `VecDeque`, taking from `Vec`'s impls.
@MrGVSV MrGVSV moved this to In Progress in Reflection Oct 15, 2022
@james7132 james7132 mentioned this issue Dec 3, 2022
Closed
@bors bors bot closed this as completed in b37a6ca Dec 11, 2022
Repository owner moved this from In Progress to Done in Reflection Dec 11, 2022
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@ItsDoot @james7132 @alradish
Add reflection support for VecDeque (bevyengine#6831)
ace8653 
# Objective
This is an adoption of bevyengine#5792. Fixes bevyengine#5791.

## Solution
Implemented all the required reflection traits for `VecDeque`, taking from `Vec`'s impls.

---

## Changelog
Added: `std::collections::VecDeque` now implements `Reflect` and all relevant traits.

Co-authored-by: james7132 <[email protected]>
ItsDoot added a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@ItsDoot @james7132
Add reflection support for VecDeque (bevyengine#6831)
18a4227 
# Objective
This is an adoption of bevyengine#5792. Fixes bevyengine#5791.

## Solution
Implemented all the required reflection traits for `VecDeque`, taking from `Vec`'s impls.

---

## Changelog
Added: `std::collections::VecDeque` now implements `Reflect` and all relevant traits.

Co-authored-by: james7132 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Feature A new feature, making something new possible
Projects
Reflection
Status: Done
Milestone
No milestone
2 participants
@ItsDoot @NathanSWard