Add unregister_system for Commands #16266
Labels
A-ECS
Entities, components, systems, and events
C-Feature
A new feature, making something new possible
S-Ready-For-Implementation
This issue is ready for an implementation PR. Go for it!
Comments
viridia
added
C-Feature
BenjaminBrienen
added
A-ECS
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 12, 2024
# Objective Fixes #16266 ## Solution Added an `UnregisterSystem` command struct and `Commands::unregister_system`. Also renamed `World::remove_system` and `World::remove_system_cached` to `World::unregister_*` ## Testing It's a fairly simple change, but I tested locally to ensure it actually works. --------- Co-authored-by: Benjamin Brienen <[email protected]>
mockersf
pushed a commit
that referenced
this issue
Nov 16, 2024
# Objective Fixes #16266 ## Solution Added an `UnregisterSystem` command struct and `Commands::unregister_system`. Also renamed `World::remove_system` and `World::remove_system_cached` to `World::unregister_*` ## Testing It's a fairly simple change, but I tested locally to ensure it actually works. --------- Co-authored-by: Benjamin Brienen <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this issue
Dec 2, 2024
# Objective Fixes bevyengine#16266 ## Solution Added an `UnregisterSystem` command struct and `Commands::unregister_system`. Also renamed `World::remove_system` and `World::remove_system_cached` to `World::unregister_*` ## Testing It's a fairly simple change, but I tested locally to ensure it actually works. --------- Co-authored-by: Benjamin Brienen <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this issue
Jan 6, 2025
# Objective Fixes bevyengine#16266 ## Solution Added an `UnregisterSystem` command struct and `Commands::unregister_system`. Also renamed `World::remove_system` and `World::remove_system_cached` to `World::unregister_*` ## Testing It's a fairly simple change, but I tested locally to ensure it actually works. --------- Co-authored-by: Benjamin Brienen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
Commandscurrently has aregister_systemmethod, but no way to unregister systems. Unregistration is very useful in on_remove hooks.What solution would you like?
Add an
unregister_systemmethod toCommands.What alternative(s) have you considered?
There are several alternatives, such as writing a custom command for this, but it would be cleaner (and more symmetrical) if this was provided on Commands directly.
The text was updated successfully, but these errors were encountered: