Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Query::for_each_unchecked_manual #10772

Closed
alice-i-cecile opened this issue Nov 28, 2023 · 4 comments
Closed

Deprecate Query::for_each_unchecked_manual #10772

alice-i-cecile opened this issue Nov 28, 2023 · 4 comments
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member 

          Should we deprecate this function too?

Originally posted by @JoJoJet in #6773 (comment)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Nov 28, 2023
@alice-i-cecile
Copy link
Member Author

Just follow the pattern in the linked PR :)

@asuratos asuratos mentioned this issue Nov 30, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 1, 2023
@asuratos
Deprecate QueryState::for_each_unchecked (#10815)
cbf39b7 
# Objective

Resolves Issue #10772.

## Solution

Added the deprecated warning for QueryState::for_each_unchecked, as
noted in the comments of PR #6773.
Followed the wording in the deprecation messages for `for_each` and
`for_each_mut`
@hecksmosis
Copy link
Contributor

I'll work on this

@hecksmosis
Copy link
Contributor

This is no longer an issue as Query::for_each_unchecked_manual has been removed I believe

@torsteingrindvik
Copy link
Contributor

Yes- removed in 2148518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alice-i-cecile @joseph-gio @torsteingrindvik @hecksmosis