Fix example canvas growing on resize #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also do this fix on https://github.com/bevyengine/bevy-website/blob/main/templates/example-webgpu.html? |
Use single quotes instead to match existing code. Move progress bar variable declarations.
|
Done. Might deduplicate this later since we have a templating system already. |
cart
approved these changes
May 19, 2023
Definitely! After the 0.11 release. The WebGL2 example should become closer to the WebGPU page, list every example with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the
fit_canvas_to_parentsetting from growing the canvas by locking the aspect ratio to that of the initial resolution of the bevyWindow.Fixes #432.