Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15 Editorial Pass 2 #1840

Merged
merged 5 commits into from
Nov 27, 2024
Merged

0.15 Editorial Pass 2 #1840

merged 5 commits into from
Nov 27, 2024

Conversation

cart
Copy link
Member

@cart cart commented Nov 23, 2024

@cart cart added this to the Release v0.15 milestone Nov 23, 2024
@alice-i-cecile
Copy link
Member

We shouldn't merge this until the linked animation PR lands, to make sure we're actually showing the final API.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes! It's a bit sad not to have the code snippet not be runnable via copy-paste, but that's fine.

@cart
Copy link
Member Author

cart commented Nov 26, 2024

I like these changes! It's a bit sad not to have the code snippet not be runnable via copy-paste, but that's fine.

Definitely a loss, but imo we should always prioritize space + reader-mental-bandwidth in blog posts

@cart
Copy link
Member Author

cart commented Nov 26, 2024

Just accounted for changes in bevyengine/bevy#16484. This should be ready to merge once that lands

@cart
Copy link
Member Author

cart commented Nov 27, 2024

Merging this now as I've kicked off the merge of bevyengine/bevy#16484

@cart cart added this pull request to the merge queue Nov 27, 2024
Merged via the queue into bevyengine:main with commit 351e7df Nov 27, 2024
10 checks passed
@cart cart deleted the 0.15-pass-2 branch November 27, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants