Simplify miniatures #1660
Merged
Simplify miniatures #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On older versions, VisualElements were not as flexible as they are now, lets uses Visuals that are much easier to render the series miniatues.
The `GetMiniaturesSketch` method has been marked as obsolete in several classes, including `BarSeries`, `CoreBoxSeries`, `CoreFinancialSeries`, `CoreHeatSeries`, `CoreLineSeries`, `CorePieSeries`, `CorePolarLineSeries`, `CoreScatterSeries`, `CoreStepLineSeries`, and `Series`.
Introduce GetMiniature method in BarSeries, CoreBoxSeries, CoreFinancialSeries, CoreHeatSeries, CoreLineSeries, CorePieSeries, CorePolarLineSeries, CoreScatterSeries, and CoreStepLineSeries. This method returns a GeometryVisual object with properties like Fill, Stroke, Width, and Height for visual representation in UI elements.
Replaced `GetMiniaturesSketch().AsDrawnControl(s_zIndex)` with `GetMiniature(s_zIndex)` across multiple files for consistency and clarity. This change affects the `CustomLegend`, `CustomTooltip`, `SKDefaultLegend`, and `SKDefaultTooltip` classes. - In `CustomLegend.cs`, replaced the commented-out `series.GetMiniature(s_zIndex)` with `GetMiniature(s_zIndex)`. - In `CustomTooltip.cs`, replaced the removed `GetMiniaturesSketch().AsDrawnControl(s_zIndex)` with `GetMiniature(s_zIndex)`. - In `SKDefaultLegend.cs`, replaced `GetMiniaturesSketch().AsDrawnControl(s_zIndex)` with `GetMiniature(s_zIndex)`. - In `SKDefaultTooltip.cs`, replaced `GetMiniaturesSketch().AsDrawnControl(s_zIndex)` with `GetMiniature(s_zIndex)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shape of the series shown in legends/tooltips uses an old api, now the library has better ways to handle that.
This PR updates the library and uses
VisualElementsto define the shapes in the miniature geommetry in tooltips/legends.It also fixes:
That issue has caused confusion in the library, like #1507, #913