Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Refactorise la facon dont on recupere le temps passé par question dans les exports #1823

Merged
merged 1 commit into from
Jan 20, 2025
Merged

♻️ Refactorise la facon dont on recupere le temps passé par question dans les exports #1823

merged 1 commit into from
Jan 20, 2025

Conversation

Marionvel
Copy link

No description provided.

@Marionvel Marionvel force-pushed the refactorise-le-code-du-temps-passe-dans-export branch from 726037f to f48ad7d Compare January 17, 2025 09:59
@etienneCharignon etienneCharignon force-pushed the refactorise-le-code-du-temps-passe-dans-export branch from f48ad7d to dbae7bf Compare January 17, 2025 13:55
etienneCharignon
etienneCharignon approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@etienneCharignon etienneCharignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super ! merci.

@etienneCharignon
Copy link
Member

Quand je vois que tout le code est dans le dossier models, je comprends la réticence de Clément à ajouter ici une dépendance vers ApplicationHelper. Du coup, on a trouvé un axe de travail pour la division de cet énorme code en morceau. Il faudrait séparer ce qui tient de la vue et ce qui tient du modèle et déplacer une partie du code dans le dossier views

@Marionvel Marionvel force-pushed the refactorise-le-code-du-temps-passe-dans-export branch 12 times, most recently from 993742d to 1238b84 Compare January 20, 2025 10:13
@Marionvel Marionvel force-pushed the refactorise-le-code-du-temps-passe-dans-export branch from 1238b84 to 2e6a98b Compare January 20, 2025 10:16
@cprodhomme cprodhomme merged commit fff18d6 into develop Jan 20, 2025
5 checks passed
@cprodhomme cprodhomme deleted the refactorise-le-code-du-temps-passe-dans-export branch January 20, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etienneCharignon etienneCharignon etienneCharignon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marionvel @etienneCharignon @cprodhomme