-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration jest => vitest WIP #4806
base: main
Are you sure you want to change the base?
Conversation
3314332
to
cc3caad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super travail, merci @Shamzic .
Juste quelques petites questions mais sur le fond ok.
Il y a aussi la question de la vulnérabilité avec glob mais bon c'est pour du test, ça devrait le faire.
@@ -109,7 +125,7 @@ describe("benefit descriptions", function () { | |||
.replace(/\s\s+/g, " ") | |||
.trim() | |||
expect(innerText.length).toBeGreaterThanOrEqual(10) | |||
expect(innerText.length).toBeLessThanOrEqual(420) | |||
expect(innerText.length).toBeLessThanOrEqual(550) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu as fait un upgrade par rapport à mes aides vélos ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non, c'est des aides au covoiturage qui ont des descriptions trop longues :
FAIL tests/integration/benefits-description.spec.ts > benefit descriptions > cc_serein_et_armance > cc-serein-et-armance-incitations-covoiturage-eligibilite > should have a description
AssertionError: expected 522 to be less than or equal to 420
❯ tests/integration/benefits-description.spec.ts:129:38
127| expect(innerText.length).toBeGreaterThanOrEqual(10)
128| console.log("BENEFIT : ", benefit)
129| expect(innerText.length).toBeLessThanOrEqual(420)
| ^
130| })
131|
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[185/186]⎯
FAIL tests/integration/benefits-description.spec.ts > benefit descriptions > metropole_daix_marseille_provence > metropole-daix-marseille-provence-incitations-covoiturage-eligibilite > should have a description
AssertionError: expected 486 to be less than or equal to 420
❯ tests/integration/benefits-description.spec.ts:129:38
127| expect(innerText.length).toBeGreaterThanOrEqual(10)
128| console.log("BENEFIT : ", benefit)
129| expect(innerText.length).toBeLessThanOrEqual(420)
| ^
130| })
131|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je propose de les remettre à jour avec les dates qu'on a. L'aide est potentiellement plus dispo. Tu en penses quoi @yasmine-glitch ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je propose un vote également pour toi @Shamzic
👍 pour maj les aides avant la merge de celle-ci
👎 pour maj l'aide afin que la description rentre dans les 420 caractères
🥇 pour passer de 420 à 550.
8c396a8
to
7d35929
Compare
4c38a0a
to
cfe3d58
Compare
bfede67
to
7f81a6b
Compare
Suite aux difficulté de compatibilité de Jest avec la version de vue 3.5, je propose de migrer les tests unitaires avec la lib Vitest qui me semble plus à jour et car c'est aussi la recommandation par défaut du framework.
À investiguer: