Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue stats #3937

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Fix issue stats #3937

merged 3 commits into from
Sep 4, 2023

Conversation

baptou12
Copy link
Contributor

@baptou12 baptou12 commented Sep 1, 2023

Ça règles deux soucis :

  • On avait un soucis de génération des stats apparement en prod car il n'arrivait pas a import import utc from "dayjs/plugin/utc" sans l'extension.
  • On ne voyait pas l'erreur car on a pas vraiment accès aux log de la tâche cron, ou du moins pas facilement : desormais ça sera sur Sentry

Petite amélioration en plus : mettre la date de calcul des stats, ça permettra de l'afficher dans mes-aides-analytics

@baptou12 baptou12 added the development PR label for standard developments label Sep 1, 2023
@baptou12 baptou12 requested a review from a team September 4, 2023 08:39
Copy link
Contributor

@Cugniere Cugniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi ; à noter qu'on peut aussi ajouter une règle de lint pour contrôler la présence d'une extension (ici ".js") en fin d'import lorsqu'on cible directement un fichier.

@baptou12 baptou12 merged commit 81981b2 into master Sep 4, 2023
30 checks passed
@baptou12 baptou12 deleted the fix_issue_stats branch September 4, 2023 12:48
@guillett guillett added this to the BC 1406243900 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development PR label for standard developments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants