Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer URL check #3670

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Defer URL check #3670

merged 2 commits into from
Dec 16, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 13, 2023 •
edited
Loading

  • Skip URL check before requesting information
  • Create button for board information [thinking about moving to a better place - after selecting target - before build]

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 13, 2023
@haslinghuis haslinghuis self-assigned this Dec 13, 2023
@haslinghuis haslinghuis marked this pull request as draft December 13, 2023 19:01
@haslinghuis haslinghuis changed the title Skip URL check and change Wiki to Support Defer URL check and change Wiki to Support Dec 13, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis marked this pull request as ready for review December 13, 2023 23:13
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 14, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

nerdCopter
nerdCopter approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving for when ready

@ctzsnooze
Copy link
Member

I think that the new home for Wiki files, on betaflight.com, needs to be Support/Wiki, not Support/Archive.
Let's confirm that before this one.

@nerdCopter
Copy link
Member

[...] Support/Wiki, not Support/Archive [...]

agree, imho.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@haslinghuis haslinghuis changed the title Defer URL check and change Wiki to Support Defer URL check Dec 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit d76152b into betaflight:master Dec 16, 2023
8 checks passed
@haslinghuis haslinghuis deleted the skip-url-check branch December 16, 2023 19:25
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Defer URL check (betaflight#3670)
6f6094e 
* Skip URL check and change Wiki to Support

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

@chmelevskij chmelevskij chmelevskij approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@blckmn blckmn Awaiting requested review from blckmn

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@haslinghuis @blckmn @ctzsnooze @nerdCopter @chmelevskij