Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate variables in datadir used for globs #329 #333

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

oneiros
Copy link
Collaborator

@oneiros oneiros commented Mar 14, 2024

Found it!

When interpolating globs we need the current datadir. But at that point, interpolation of variables in the datadir itself was not yet done. So anytime a glob was used, it was taking any variables in the datadir's path literally.

The commit here fixes this.

Fixes #329

@oneiros oneiros requested a review from a team as a code owner March 14, 2024 14:47
@bastelfreak bastelfreak added the bug Something isn't working label Mar 14, 2024
Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this locally, but it looks good to me.

@oneiros oneiros merged commit be7dc39 into main Mar 21, 2024
10 checks passed
@oneiros oneiros deleted the issue-329 branch March 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

globs do not show data on v2.0.0
2 participants