Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update google-protobuf to 3.25.3 to be compatible with ruby-3.3.0 #315

Closed
wants to merge 1 commit into from
Closed

Update google-protobuf to 3.25.3 to be compatible with ruby-3.3.0 #315

wants to merge 1 commit into from

Conversation

marcusdots
Copy link
Contributor

Fix: #313

@marcusdots marcusdots requested a review from a team as a code owner March 1, 2024 10:42
@marcusdots marcusdots enabled auto-merge March 1, 2024 10:44
@oneiros
Copy link
Collaborator

oneiros commented Mar 1, 2024

Please note that I had to fix this in #283 to get the branch up-to-date and checks green. If I understood it correctly, that branch is to be merged asap in which case this here is no longer needed.

(Sorry you had to duplicate efforts here. I did leave a note in #313 though.)

@rwaffen rwaffen mentioned this pull request Mar 1, 2024
Closed
@rwaffen
Copy link
Member

rwaffen commented Mar 1, 2024

superseded by #283

@rwaffen rwaffen closed this Mar 1, 2024
auto-merge was automatically disabled March 1, 2024 10:52

Pull request was closed

@rwaffen rwaffen deleted the mp_fix_protobuf_ruby330 branch March 1, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Bug with google-protobuf-3.25.2-x86_64-linux
3 participants
@marcusdots @oneiros @rwaffen