Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bootstrap from 4.6.2 to 5.3.2 #207

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 26, 2023

Bumps bootstrap from 4.6.2 to 5.3.2.

Commits
  • cf24341 Update to v5.3.2
  • 76f3973 Add missing rails_server dev dependencies
  • 4b35084 Add bootstrap-utilities to list of main files
  • 3903cf3 Add bundler/setup to Rakefile
  • 8ae3977 Add rake dev dependency
  • fde1edf Soft-dependency to Sass to allow Dart Sass
  • 07f432e Update to v5.3.1
  • cfee773 Update to v5.3.0
  • e7c1749 Update to v5.3.0.alpha3
  • ba51ab2 Fixup tasks/updater for v5.3.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner October 26, 2023 13:28
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 26, 2023
@oneiros
Copy link
Collaborator

oneiros commented Nov 2, 2023

We discussed what it would take to make this update. To get a better feeling for that, I just updated the gem and had a look at what breaks.

Here is an example screenshot:

image

Some changes are to be expected, e.g. in bootstrap 5 -left and -right classes were renamed to better support RTL languages, so the user dropdown in the navigation being left-aligned is no surprise.

Some changes are very subtle (spacing for example), but pose no problem imo.

The display of the accordion, the search icon and the "Only from selected environment" are problematic however. I expect all of them to have a more or less easy fix, but this is only one screen and I fear these small things might add up quickly.

The biggest problem though is that the JavaScript (e.g. for the dropdown and the accordion) is not working at all.

So an update is not trivial and might take anywhere from a couple of hours to a week.

@dependabot dependabot bot force-pushed the dependabot/bundler/bootstrap-5.3.2 branch 3 times, most recently from bb0f4ec to 9dca28f Compare November 6, 2023 14:56
@oneiros oneiros mentioned this pull request Nov 7, 2023
@dependabot dependabot bot force-pushed the dependabot/bundler/bootstrap-5.3.2 branch 3 times, most recently from 9227669 to 9402e26 Compare November 14, 2023 11:24
@dependabot dependabot bot force-pushed the dependabot/bundler/bootstrap-5.3.2 branch from 9402e26 to 23350ea Compare November 23, 2023 08:04
Bumps [bootstrap](https://github.com/twbs/bootstrap-rubygem) from 4.6.2 to 5.3.2.
- [Release notes](https://github.com/twbs/bootstrap-rubygem/releases)
- [Changelog](https://github.com/twbs/bootstrap-rubygem/blob/main/CHANGELOG.md)
- [Commits](twbs/bootstrap-rubygem@v4.6.2...v5.3.2)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/bootstrap-5.3.2 branch from 23350ea to 4759520 Compare November 23, 2023 08:10
@bastelfreak
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 7, 2023

Looks like bootstrap is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Dec 7, 2023
@dependabot dependabot bot deleted the dependabot/bundler/bootstrap-5.3.2 branch December 7, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants