Display value differences to actual environment #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a key is displayed from a different environment than the node is actually in _and_ a file with the same path exists in the original environment _and_ the value in that file differs from the one displayed, show the differences. Uses the `diffy` gem to highlight the differences.
rwaffen
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
When displaying a value from a different environment, this will now display differences to the value from the same file in the original environment of the node (if those exist).
From the issue:
I actually opted for a bit of both. I started by using the
diffygem (https://github.com/samg/diffy) to visualize the diff. This worked really nicely, but I (think) I initially switched original and changed value, so when displaying this vertically stacked it was not very clear which was which. Luckily,diffyhas a nice side-by-side functionality that I could use to create a table where I can use column headings to make it crystal clear which value is from which environment.This is how it looks (the node I selected is in the
globsenvironment, but here I chosedevelopmentinstead):The tabs are only displayed if there really is a differing value in the original environment. I am not 100% happy with the labels on the tabs ("Value" and "Diff"). If you have a better idea, please let me know.
The
diffygem actually shells out to the command linediffutility, so this creates an implicit dependency on that. Given that it is available in most systems and more importantly in all official ruby docker images I think this is not a problem.