Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: integration test #33

Merged
merged 1 commit into from
Dec 30, 2022
Merged

fix: integration test #33

merged 1 commit into from
Dec 30, 2022

Conversation

Abirdcfly
Copy link
Member

Signed-off-by: Abirdcfly [email protected]

@Abirdcfly Abirdcfly force-pushed the fixintegrationtest branch 4 times, most recently from 5f881eb to 134b9d3 Compare December 29, 2022 08:22
@Abirdcfly
Copy link
Member Author

Integration Test / suite (ca) still fails and so does upstream, should be a problem with the part we haven't changed yet, need to keep working on it, will submit it as an additional pr later.

@Abirdcfly Abirdcfly marked this pull request as ready for review December 29, 2022 08:35
@Abirdcfly
fix: integration test
ad6d351 
Signed-off-by: Abirdcfly <[email protected]>
@Abirdcfly Abirdcfly mentioned this pull request Dec 30, 2022
Closed
@bjwswang bjwswang merged commit 65bf5f7 into bestchains:main Dec 30, 2022
@Abirdcfly
Copy link
Member Author

see hyperledger-labs#89

@Abirdcfly Abirdcfly deleted the fixintegrationtest branch December 30, 2022 07:24
@Abirdcfly Abirdcfly mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjwswang bjwswang bjwswang approved these changes

@0xff-dev 0xff-dev Awaiting requested review from 0xff-dev

@nkwangleiGIT nkwangleiGIT Awaiting requested review from nkwangleiGIT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @bjwswang