Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

128 add more information on test structure #207

Merged
merged 8 commits into from
Nov 25, 2024
Merged

128 add more information on test structure #207

merged 8 commits into from
Nov 25, 2024

Conversation

Jday7879
Copy link
Contributor

Adding more detail on test structure including:

  • Reasons to separate tests and main code when packaging
  • class inherritence for tests in python
  • context structure for R
  • best ways to structure tests and importing module

@Jday7879 Jday7879 linked an issue Nov 11, 2024 that may be closed by this pull request
Add more information on test structure #128
Closed
sarahcollyer
sarahcollyer requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@sarahcollyer sarahcollyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few tweaks but most of them are just cleaning up grammar and typos.

book/testing_code.md Outdated Show resolved Hide resolved
book/testing_code.md Outdated Show resolved Hide resolved
book/testing_code.md Show resolved Hide resolved
book/testing_code.md Outdated Show resolved Hide resolved
book/testing_code.md Outdated Show resolved Hide resolved
book/testing_code.md Outdated Show resolved Hide resolved
book/testing_code.md Outdated Show resolved Hide resolved
book/testing_code.md Outdated Show resolved Hide resolved
@Jday7879
Updated info on contexts now being depreciated
3a7f88b
@Jday7879
Replaces its to it is
88fbedc
@Jday7879
Formatting changes:
0df846c 
- Adding links to python and R test structure guide
- sp recommended
- add s to function
@Jday7879
Copy link
Contributor Author

Reworked section on R contexts. Added links to R and Python test documentation where requested. Fixed typos

@ellie-o ellie-o self-requested a review November 21, 2024 16:45
ellie-o
ellie-o approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@ellie-o ellie-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, but Sarah needs to resolve thread and merge

@ellie-o ellie-o removed the request for review from sarahcollyer November 21, 2024 16:48
@sarahcollyer sarahcollyer merged commit bb8681b into main Nov 25, 2024
1 check passed
@sarahcollyer sarahcollyer deleted the 128-add-more-information-on-test-structure branch November 25, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahcollyer sarahcollyer sarahcollyer approved these changes

@ellie-o ellie-o ellie-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more information on test structure
3 participants
@Jday7879 @ellie-o @sarahcollyer