Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glossary #186

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Update glossary #186

merged 8 commits into from
Jul 3, 2024

Conversation

gisellerosetta
Copy link
Contributor

Have changed some of the suggested definitions from #173; also included 'interactive running', 'procedural running' and 'attribute' as these are used in other definitions.

Added dual running as understood in the RAP context in #168.

Actioned the suggestions on #185.

Copy link
Contributor

@sarahcollyer sarahcollyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple of really minor and easy-to-fix things; once these are done happy for this to be merged.

  • 'Code interpreter' needs to be bold
  • Can we capitalise all words in GCP, AWS and the Azure after Microsoft in the Cloud computing description? So it reads Google Cloud Platform instead of Google cloud platform.

Thanks! 😸

@gisellerosetta
Copy link
Contributor Author

Thanks Sarah - I'll also investigate more why the CI is failing

@gisellerosetta
Copy link
Contributor Author

CI was failing because I deleted a subtitle, which lead to style warnings about header levels that we then don't allow for in the workload build command. Thanks @danmilne1 for the spot.

@sarahcollyer sarahcollyer merged commit bb4f56b into main Jul 3, 2024
1 check passed
@sarahcollyer sarahcollyer deleted the update-glossary branch July 3, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants