Emphasise that review needs to be continuous #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of my changes here aren't very clear or concise, so I'm keen to hear any suggestions for improving them! |
RuSnook
suggested changes
Feb 3, 2023
Co-authored-by: Ru Snook <[email protected]>
Co-authored-by: Ru Snook <[email protected]>
|
I've added a bit more content here and restructured the page to use active headings as per #86. I haven't finished yet - I'd like to cut down the "Why" section and rephrase other parts to emphasise the action in the headings |
RuSnook
suggested changes
Feb 16, 2023
Co-authored-by: Ru Snook <[email protected]>
|
Biggest changes were around what are now the first two sections. I'm still not totally happy with them, so keen to have a second opinion please! |
RuSnook
suggested changes
Feb 22, 2023
RuSnook
approved these changes
Feb 22, 2023
rowanhemsi
reviewed
Mar 9, 2023
This was referenced Mar 13, 2023
rowanhemsi
reviewed
Mar 13, 2023
There was a problem hiding this comment.
This looks good, thanks for addressing my earlier feedback
Only other thing is a general reminder of the Hemingway app, which can help pick up readability issues like a couple of the wordier sentences I flagged before
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.