feature: Patch Serial.in_waiting too #24

zed · 2024-07-23T08:31:32Z

Allow replaying serial port interactions that use Serial.in_waiting.

fix: raise PortNotOpenError on read/write to a closed serial port, so that the replay behavior would be closer to the real one
ci: report missing statements in the coverage report, to see what should be tested
chore: remove unused noqa directive, to fix the corresponding lint error.

It fixes lint error: ```shell $ tox ... RUF100 [*] Unused `noqa` directive (unused: `ARG001`) ```

100% coverage

Denis Patrikeev added 6 commits July 23, 2024 11:09

ci(coverage): report missing statements

5e53b6b

fix: raise PortNotOpenError on read/write from closed serial port

37a2d9e

test(replay): PortNotOpenError raised on read/write to closed port

3cd126f

feat: patch Serial.in_waiting too

a27508c

chore: remove unused noqa directives

6fc2b51

It fixes lint error: ```shell $ tox ... RUF100 [*] Unused `noqa` directive (unused: `ARG001`) ```

test: Serial.in_waiting

9edc7f1

100% coverage

zed mentioned this pull request Jul 23, 2024

no attribute 'pipe_abort_read_r' on --replay #23

Closed

bessman approved these changes Jul 23, 2024

View reviewed changes

bessman merged commit 70ec0a9 into bessman:main Jul 23, 2024
6 checks passed

zed deleted the feature/in_waiting branch July 23, 2024 09:20

Provide feedback