Compile error with gcc 15-20241117 -Wunterminated-string-initialization

[heitbaum]

libxcrypt/lib/util-base64.c

Lines 23 to 27 in dabbc15

	const unsigned char ascii64[65] =
	"./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
	/* 0000000000111111111122222222223333333333444444444455555555556666 */
	/* 0123456789012345678901234567890123456789012345678901234567890123 */
	"\x00";

/bin/dash ./libtool  --tag=CC   --mode=compile /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/libxcrypt-4.4.36  -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/libxcrypt-4.4.36/lib -DIN_LIBCRYPT  -Wall -Wextra -Walloc-zero -Walloca -Wbad-function-cast -Wcast-align -Wcast-qual -Wconversion -Wformat=2 -Wformat-overflow=2 -Wformat-signedness -Wformat-truncation=1 -Wlogical-op -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wnull-dereference -Wold-style-definition -Wpointer-arith -Wrestrict -Wshadow -Wstrict-overflow=2 -Wstrict-prototypes -Wundef -Wvla -Wwrite-strings -Wpedantic -Werror -fno-plt -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -MT lib/libcrypt_la-util-xbzero.lo -MD -MP -MF lib/.deps/libcrypt_la-util-xbzero.Tpo -c -o lib/libcrypt_la-util-xbzero.lo `test -f 'lib/util-xbzero.c' || echo '/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/build/libxcrypt-4.4.36/'`lib/util-xbzero.c
../lib/util-base64.c:24:3: error: initializer-string for array of 'unsigned char' is too long [-Werror=unterminated-string-initialization]
   24 |   "./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

• similar issue at Fixed -Wunterminated-string-initialization with GCC 15. nginx/nginx#134

[WentsingNee]

me too

microsoft/vcpkg#41695

[besser82]

@heitbaum and @WentsingNee Can you please confirm the referenced commit does fix your issue?

[WentsingNee]

@heitbaum and @WentsingNee Can you please confirm the referenced commit does fix your issue?

yes, adjusting array size can fix my issue

[besser82]

Can you please re-check with the updated commit?

[heitbaum]

55bc82b Builds fine
05814bd Does not

../lib/util-base64.c:24:3: error: initializer-string for array of 'unsigned char' is too long [-Werror=unterminated-string-initialization]
   24 |   "./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz\0";
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[heitbaum]

It does build with the \0 removed

--- a/lib/util-base64.c
+++ b/lib/util-base64.c
@@ -21,7 +21,6 @@
 #include "crypt-port.h"
 
 const unsigned char ascii64[65] =
-  "./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
-/* 0000000000111111111122222222223333333333444444444455555555556666 */
-/* 0123456789012345678901234567890123456789012345678901234567890123 */
-  "\x00";
+  "./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
+/* 0000000000111111111122222222223333333333444444444455555555556666\0 */
+/* 0123456789012345678901234567890123456789012345678901234567890123\0 */

[besser82]

It does build with the \0 removed

--- a/lib/util-base64.c
+++ b/lib/util-base64.c
@@ -21,7 +21,6 @@
 #include "crypt-port.h"
 
 const unsigned char ascii64[65] =
-  "./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
-/* 0000000000111111111122222222223333333333444444444455555555556666 */
-/* 0123456789012345678901234567890123456789012345678901234567890123 */
-  "\x00";
+  "./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
+/* 0000000000111111111122222222223333333333444444444455555555556666\0 */
+/* 0123456789012345678901234567890123456789012345678901234567890123\0 */

Fixed that way in 819352f.