Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMG Installer skipped -- app identifier must be specified #74

Closed
msgilligan opened this issue Aug 6, 2019 · 6 comments
Closed

DMG Installer skipped -- app identifier must be specified #74

msgilligan opened this issue Aug 6, 2019 · 6 comments

Comments

@msgilligan
Copy link

msgilligan commented Aug 6, 2019

On macOS I'm trying to build a DMG image and getting the following error:

Bundler DMG Installer skipped because of a configuration problem: When using an external app image you must specify the identifier.. 
Advice to fix: Set the identifier via the -appId CLI flag, the fx:application/@id ANT attribute, or via the 'identifier' bundler argument.

I have Build 8 (2019/6/21) of jpackage installed in BADASS_JLINK_JPACKAGE_HOME.

My jlink block:

jlink {
    addExtraDependencies("javafx")
    options = ['--strip-debug', '--compress', '2', '--no-header-files', '--no-man-pages']
    launcher {
        name = 'WalletTemplate'
        jvmArgs = []
    }
    jpackage {
        jpackageHome = System.getenv('BADASS_JLINK_JPACKAGE_HOME')
        skipInstaller = false
        installerType = "dmg"
    }
}

Note: Copying the actual generated jpackage command and adding --identifier WalletTemplate seems to produce a valid DMG.

@siordache
Copy link
Member

I will look into it. In the meantime, try this:

jpackage {
    jpackageHome = System.getenv('BADASS_JLINK_JPACKAGE_HOME')
    skipInstaller = false
    installerType = "dmg"
    installerOptions = ["--identifier", "WalletTemplate"]
}

@msgilligan
Copy link
Author

Good suggestion, I will try that.

@msgilligan
Copy link
Author

Yes, that seems to work. So we could just document as a mandatory option, or automatically set it by default.

@siordache
Copy link
Member

In 2.14.1, the plugin sets the --identifier option by itself.
Default value: the main class.
Ìn the jpackage block you can now customize this value using the newly introduced property identifier.

@msgilligan
Copy link
Author

This seems to work. Thanks!

@gleidsonmt
Copy link

Oh god, thanks..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants