Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for the shortcut in system menu is the default (duke) icon #235

Closed
showbags opened this issue Sep 12, 2023 · 2 comments
Closed

Icon for the shortcut in system menu is the default (duke) icon #235

showbags opened this issue Sep 12, 2023 · 2 comments

Comments

@showbags
Copy link
Contributor

It looks as though the icon specified in the jpackage section is ignored. Consequently duke shows up as the icon regardless of what is specified.

@showbags
Copy link
Contributor Author

I don't seem to be able to create a branch to address this issue. Nor does github allow me to upload a patch file here. Here is a patch which resolves this issue:

Index: src/main/groovy/org/beryx/jlink/impl/JPackageTaskImpl.groovy
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/main/groovy/org/beryx/jlink/impl/JPackageTaskImpl.groovy b/src/main/groovy/org/beryx/jlink/impl/JPackageTaskImpl.groovy
--- a/src/main/groovy/org/beryx/jlink/impl/JPackageTaskImpl.groovy	(revision f293e39fcf481e755a03ab7267f6fe55657bcaaf)
+++ b/src/main/groovy/org/beryx/jlink/impl/JPackageTaskImpl.groovy	(revision 7b7e07795a5705ac8421189ce6cb5815df3bcb7d)
@@ -88,6 +88,7 @@
 
                 final def resourceDir = jpd.resourceDir
                 final def resourceOpts = (resourceDir == null) ? [] : [ '--resource-dir', resourceDir ]
+                final def iconOpts = jpd.icon ? [ '--icon', jpd.icon ] : []
 
                 commandLine = [jpackageExec,
                                '--type', packageType,
@@ -97,7 +98,8 @@
                                *vendorOpts,
                                '--app-image', "$appImagePath",
                                *resourceOpts,
-                               *jpd.installerOptions]
+                               *jpd.installerOptions,
+                               *iconOpts]
             }
             if(result.exitValue != 0) {
                 LOGGER.error(project.ext.jpackageInstallerOutput())

showbags added a commit to showbags/badass-jlink-plugin that referenced this issue Sep 13, 2023
airsquared pushed a commit to showbags/badass-jlink-plugin that referenced this issue Sep 24, 2023
airsquared added a commit that referenced this issue Sep 24, 2023
@airsquared airsquared added the Pending Release This issue has been fixed in master and is awaiting a release label Sep 24, 2023
@airsquared
Copy link
Collaborator

Fixed in v3.0.0.

@airsquared airsquared removed the Pending Release This issue has been fixed in master and is awaiting a release label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants