Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application.applicationDefaultJvmArgs not taking effect in launcher #197

Closed
tbnguyen1407 opened this issue Sep 16, 2021 · 1 comment
Closed

Comments

@tbnguyen1407
Copy link

tbnguyen1407 commented Sep 16, 2021

Version:

2.24.1

Problem:

jlink.launcher.jvmArgs does not default to application.applicationDefaultJvmArgs as documented

jvmArgs
  list of JVM arguments to be passed to the java executable.
  defaultValue: the arguments configured in the applicationDefaultJvmArgs property of the application extension

Reproduction:

Original:

git clone https://github.com/beryx-gist/badass-jlink-example
cd badadd-jlink-example
./gradlew clean jlink

Output 1:

~ build/image/bin/hello ~
"$DIR/java" $CDS_JVM_OPTS -Dlogback.configurationFile=./logback.xml -p "$DIR/../app" -m org.beryx.modular.hello/org.beryx.modular.hello.Hello  "$@"

Modification:

~ build.gradle ~
application {
    applicationDefaultJvmArgs = ['-Dlogback.configurationFile=./logback.xml']
}

jlink {
    launcher {
        //jvmArgs = ['-Dlogback.configurationFile=./logback.xml']
    }
}

Output 2 (missing args):

~ build/image/bin/hello ~
"$DIR/java" $CDS_JVM_OPTS  -p "$DIR/../app" -m org.beryx.modular.hello/org.beryx.modular.hello.Hello  "$@"
@siordache
Copy link
Member

Fixed in 2.24.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants