Merge pull request #17 from berty/dev/moul/circle

feat: setup circle ci

.circleci/config.yml

@@ -1,22 +1,30 @@
-version: 2
+version: 2.1
+
+orbs:
+  codecov: codecov/[email protected]
+  moul: moul/[email protected]
+  tools: gotest/[email protected]
+
 jobs:
   build:
     docker:
-      - image: circleci/golang:1.12
-    #working_directory: /go/src/berty.tech/CHANGE_ME
+      - image: circleci/golang:1.13
+    working_directory: /go/src/berty.tech/yolo
     environment:
       GO111MODULE: "on"
+      #GOPROXY: "https://goproxy.io"
     steps:
       - checkout
-      #- restore_cache:
-      #    keys:
-      #      - go-mod-v1-{{ arch }}-{{ checksum "go.sum" }}
-      #      - go-mod-v1-{{ arch }}-
-      #- run: go mod download
-      #- run: make test
-      #- run: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- v1.17.1
-      #- run: PATH=$PATH:./bin make lint
-      #- save_cache:
-      #    key: go-mod-v1-{{ arch }}-{{ checksum "go.sum" }}
-      #    paths:
-      #      - /go/pkg/mod
+      - tools/mod-download
+      - tools/mod-tidy-check
+      - run: make test
+      - run: make install
+      - moul/install_golangci-lint
+      - run: make lint
+      - codecov/upload:
+          file: coverage.txt
+
+workflows:
+  main:
+    jobs:
+      - build

.golangci.yml

@@ -0,0 +1,35 @@
+run:
+  deadline: 1m
+  tests: false
+  skip-files:
+    - "test/.*"
+    - "test/.*/.*"
+
+linters-settings:
+  golint:
+    min-confidence: 0
+  maligned:
+    suggest-new: true
+  goconst:
+    min-len: 5
+    min-occurrences: 4
+  misspell:
+    locale: US
+
+linters:
+  disable-all: true
+  enable:
+    - goconst
+    - misspell
+    - deadcode
+    - misspell
+    - structcheck
+    - errcheck
+    - unused
+    - varcheck
+    - staticcheck
+    - unconvert
+    - gofmt
+    #- goimports # disabling goimports while we can't configure it to ignore vendors (github.com/whyrusleeping/go-logging seems to be badly formated)
+    - golint
+    - ineffassign

Makefile

@@ -6,6 +6,10 @@ test: generate
 install: generate
 	go install ./cmd/yolo
 
+.PHONY: lint
+lint: generate
+	golangci-lint run
+
 ##
 ## generate
 ##

pkg/plistgen/plistgen.go

@@ -7,9 +7,9 @@ import (
 func Release(bundleID, version, title, url string) ([]byte, error) {
 	release := &ApplePlistRelease{
 		Items: []*ApplePlistItem{
-			&ApplePlistItem{
+			{
 				Assets: []*ApplePlistAsset{
-					&ApplePlistAsset{
+					{
 						Kind: "software-package",
 						URL:  url,
 					},

service.go

@@ -154,7 +154,7 @@ func (svc service) PlistGenerator(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	w.Header().Add("Content-Type", "application/x-plist")
-	w.Write(b)
+	_, _ = w.Write(b)
 }
 
 func (svc service) ArtifactDownloader(w http.ResponseWriter, r *http.Request) {