Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add filter option for advertise #7

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: add filter option for advertise #7

merged 2 commits into from
Jan 16, 2023

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Nov 7, 2022

No description provided.

@gfanton gfanton self-assigned this Nov 7, 2022
@auto-add-label auto-add-label bot added the bug Something isn't working label Nov 7, 2022
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 7, 2022
@guardrails
Copy link

guardrails bot commented Nov 7, 2022 •
edited
Loading

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@gfanton gfanton force-pushed the feat/advertise-addr-factory branch 2 times, most recently from 946fc19 to 0159ff9 Compare January 10, 2023 14:14
@gfanton gfanton force-pushed the feat/advertise-addr-factory branch from 0159ff9 to 10c05aa Compare January 16, 2023 14:32
aeddi
aeddi approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@aeddi aeddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gfanton
fix: ci macos
cc08932 
Signed-off-by: gfanton <[email protected]>
@gfanton gfanton force-pushed the feat/advertise-addr-factory branch from dd4b269 to cc08932 Compare January 16, 2023 16:39
@gfanton gfanton merged commit ac45664 into berty:master Jan 16, 2023
@gfanton gfanton deleted the feat/advertise-addr-factory branch January 16, 2023 16:44
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jan 16, 2023
@github-actions
Copy link

🎉 This PR is included in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeddi aeddi aeddi approved these changes

Assignees

@gfanton gfanton

Labels
bug Something isn't working ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfanton @aeddi