Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processor.metadata_location property to specify where in the package ocrd-tool.json is found #16

Closed
wants to merge 1 commit into from

Conversation

kba
Copy link
Collaborator

@kba kba commented Aug 23, 2024

This is necessary for packages that use namespaces (like eynollah) and potentially other non-standard locations for ocrd-tool.json.

I think having this additional property in core is better than having to reimplement self.metadata, including the validation, in a processor.

Copy link
Owner

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@bertsky
Copy link
Owner

bertsky commented Aug 24, 2024

Note: I cherry-picked this in #14 and went further (see esp. 7966057): you can now override anywhere in the chain from pkg filename (renamed metadata_filename) to absolute filename (now metadata_location) via raw dict (new metadata_rawdict) to validated+expanded dict (metadata). This helps address all scenarios alike with least hurdles.

Again, thanks!

@bertsky bertsky closed this Aug 24, 2024
@bertsky bertsky mentioned this pull request Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants