fix(plugin-recaptcha): Enhance esbuild transpilation support of content scripts #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugin: puppeteer-extra
Comment on lines
+75
to
+79
| // Some bundlers transform classes to anonymous classes that are assigned to | ||
| // vars (e.g. esbuild). In such cases, `unexpected token '{'` errors are thrown | ||
| // once the script is executed. Let's bring class name back to script in such | ||
| // cases! | ||
| scriptSource = scriptSource.replace(/class \{/, `class ${scriptName} {`) |
There was a problem hiding this comment.
Hey 👋
Mind co-authoring these?
There was a problem hiding this comment.
Hey @igalklebanov yeah; for sure, I'd like to give you credit. Do I need to rebase on top of your branch as a remote or something? 🤔
There was a problem hiding this comment.
I think that simply re-comitting (remove -> add) just those lines with co-author commit message body will do. I'll close my PR once its done. Your description describes the problem better.
|
Hey @transitive-bullshit 😄👋 your early feedback was instrumental to make this project fly, thanks again :) I'll merge this PR (thanks!) in after #758 from @igalklebanov to help with the attribution |
berstend
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #758
It also fixes a fix to workaround
esbuild's__namesemantics: privatenumber/tsx#113The author of
esbuildrecommends against callingtoString()on a function or class as this library is doing and instead creating a separate build for these entrypoints. This results in a lot more deterministic functionality, but that would also involve a larger PR.So for now, this is the minimal amount of code changes to get
puppeteer-extra-plugin-recaptcha's injected content scripts to work when used in an application that's compiled usingesbuild.I ran into this issue while building the chatgpt node.js wrapper, which uses uses
tsxto transpile TS to JS on-the-fly (usingesbuildunder the hood).Also just wanted to say hey @berstend 👋 I remember working with you a bit years ago back in the early days of this project. Really really impressive to see how far it's come 🔥
Thanks for all your hard work && cheers,
-- Travis