feat: use puppeteer-core instead of puppeteer

[ratson]

This should address #262 #27 #30 #66

It seems this package is the puppeteer types rather than its functionality to download browser.

[berstend]

Hey @ratson - unfortunately @types/puppeteer-core is severely outdated :-/

This issue should be fixed in the upcoming #303 rewrite regardless, as I've ditched the peer dependencies (packages/automation-extra/package.json): https://github.com/berstend/puppeteer-extra/pull/303/files#diff-9796a6dfb75df90c2755fd54e3641cafR54-R61

Closing this PR for now, but thanks for the initiative!

[AdrKacz]

Hello, what are the options to use puppeteer-extra only with puppeteer-core? (Without downloading any browser)

[bjornlll]

@AdrKacz if you have puppeteer-core installed alongside this package it should automagically work. However, on my side it doesn't (esbuild + puppeteer-core + this package). Will let you know if I find out what the issue is.

[bjornlll]

Solved by, in esbuild, marking the models as external and manually npm installing them into the bundle.

[AdrKacz]

@bjornlll can you please share the config files that you found to resolve the issue?

[bjornlll]

Sure, but it likely won't be relevant.

sst.config.ts

const ingestDocFnParams: Omit<sst.aws.FunctionArgs, 'handler'> = {
    // ...
    nodejs: {
      install: {
        // This marks the the packages as 'external' to esbuild and manually npm installs them
        "jsdom": "npm:[email protected]",
        "@sparticuz/chromium": "131.0",
        "sharp": "*",
        "puppeteer-core": "^23.10.4",
        "puppeteer-extra": "^3.3.6",
        "puppeteer-extra-plugin-stealth": "^2.11.2",
      }
    },
  };

This solution is specific to esbuild + SST. A similar solution would probably work if you're using another bundler (webpack, vite, ...). Key is to exclude the packages from the bundle and npm install them instead.

[AdrKacz]

I'm also working with esbuild + SST so it might help more than you think ☺️
Thank you very much, I'll give it a try !

[bjornlll]

Haha! Great to hear. Then you should also know that I had to patch SST to make this work: https://github.com/bjornlll/sst. Submitted a PR to them. Not sure if/when they'll merge: sst/sst#5270

As an alternative you can also use the sst.aws.Function's bundle property to provide your own bundling logic.