Cache sass graph and make build faster #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2019 16:36
|
@ZanderZhan thanks a lot for the PR 👍 I noticed the tests are failing, could you adjust them so they pass? :-) Thanks! |
|
@berstend just adjusted and now all checks have passed |
|
@berstend merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operation System: macOS Mojave 10.14.2
Node Version: v7.10.1
In my project ,there is 410 scss file and it costs about 15 seconds when I modify a single file. There is too long for develop, but after cache sass-graph, it costs only about 1.5 seconds. So I think it's better to pull a request to improve build performance.
before:
after:
