Remove sleep calls in Start and Launch processes
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `Stop()`: simplify and add output * `getHostArchitecture()`: fix logging format bug * changes in `Start()` and `Launch()` (below) `Start()`: * use `-daemonize` and `cmd.Run(..)` * `Run()` blocks until `qemu-system` succeeds and backgrounds * clarify output * Add PID file cleanup on errors * Remove unneeded `Retry` calls (calls now block or error rather than failing silently) * Mount `mount` directories in `/mnt` per standard Linux practices `Launch()`: * Remove unneeded `Retry` (calls now block or error) * Document `sfdisk` calls
Closed
|
On my 2020 M1 this is about 14% faster. Before PR: start time 23.6s |
|
Yeah, just about same. However, I still like this PR as it ensures |
|
One possibility for faster startups could be launching a vm from a snapshot (https://wiki.qemu.org/Documentation/CreateSnapshot). On I'll explore this a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of internals cleanups and changes to remove the need for
RetryinStartandLaunch. Calls which were previously handled inRetryloops now either block until success, or exit with an error. Therefore, either the function succeeds, or does not need to retry as an error must first be resolved. Closes #79.Overall summary of edits in
qemu/ops.go:Stop(): simplify and add outputgetHostArchitecture(): fix logging format bugStart()andLaunch()(below)in
Start():-daemonizeandcmd.Run(..)cmd.Run(...)blocks untilqemu-systemsucceeds and forks to backgroundawaiting ssh, etc)Retrycalls (calls now block or error rather thanfailing silently)
mountdirectories in/mntper standard Linux practicesin
Launch():Retry(calls now block or error)sfdiskcalls