Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for brew service usage in homebrew formula #130

Merged
merged 3 commits into from
Apr 22, 2023
Merged

Prepare for brew service usage in homebrew formula #130

merged 3 commits into from
Apr 22, 2023

Conversation

maxzinkus
Copy link
Collaborator

@maxzinkus maxzinkus commented Apr 22, 2023 •
edited
Loading

Currently, the only way to get the launchctl launch agent to auto-start instances as login is to build from source and use make install && make agent.

brew supports installing plist service files in formulae (refer to brew service). It requires the plist file to be available within the project so that it can be installed:

prefix.install_symlink "file.plist" => "#{plist_name}.plist"

This PR:

  • changes make install to build the plist file once alpine is installed into $PATH
  • removes make agent

Once this is merged, I'll open a PR on the macpine formula to install the plist file into Cellar per above, so that brew service will notice it.

@maxzinkus
Prep for brew service
8c84e57 
* `make install` builds the launch agent plist into `build/`
* remove `make agent` (if people are building from source, they can
  install the plist from `build/` themselves too)
* change `bin/` to `build/` as `.plist` is not a binary
@maxzinkus
Update cli docs
26d548f
@maxzinkus maxzinkus added the enhancement New feature or request label Apr 22, 2023
@maxzinkus maxzinkus requested a review from idroz April 22, 2023 20:39
@maxzinkus maxzinkus self-assigned this Apr 22, 2023
@maxzinkus maxzinkus added the awaiting review Blocking on input from a core maintainer label Apr 22, 2023
@maxzinkus maxzinkus removed the request for review from idroz April 22, 2023 20:45
@maxzinkus maxzinkus merged commit e75c179 into beringresearch:main Apr 22, 2023
@maxzinkus maxzinkus deleted the brew-service branch April 22, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxzinkus maxzinkus

Labels
awaiting review Blocking on input from a core maintainer enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxzinkus