Handle multiple VM name arguments #112
Merged
+1,538
−1,692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized while testing `launch` that many "fun" possibilities were available to the name randomizer, including a few choice examples: * `abusive-childhood` * `superior-race` * `force-sex` Needless to say, this commit cleans up the dictionaries a little in the hopes that these and other *really unfortunate* combinations never arise.
* `delete` * `edit` * `start` * `stop`
|
@idroz :) |
|
I didn't add a |
idroz
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for multiple VM arguments.
Commands
deleteedit(passes each as an argument to$EDITOR-- vim handles this nicely using buffers)publishstartstopNotes
CmdResulttype toutils/utils.goin order to aggregate errors as we iterate through VMs. This way, one failed iteration won't cancel the remainder.alpine publish foo foowill only publish once).VM already stoppederror fromqemu/ops.go:Stop()to avoid weirdness. This now just fails silently/is idempotent.AutoCompleteVMNames()is already ready for multiple VMs, works as intended.Additional note
During testing, I ran
launchmany times. One time, I got a really unfortunate VM name from the randomizer. So, I went through the dictionaries (adjectives.txtandnouns.txt) and manually cleaned them up. No guarantee that I did a perfect job, but it should help mitigate issues in the future. In summary:person,girl,boyfriend, etc)error,data, etc)Closes #87
Closes #88
Closes #89
Closes #91