Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging vms #104

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Tagging vms #104

merged 3 commits into from
Mar 29, 2023

Conversation

maxzinkus
Copy link
Collaborator

Add support for adding and removing, and storing/printing custom string tags on VMs.

@maxzinkus
Copy link
Collaborator Author

it's designed for a small number of tags, e.g. 0-10 per VM, so the tag add/remove is done using linear scans of the tag list for simplicity rather than a more efficient but complex batched binary search.

@maxzinkus maxzinkus mentioned this pull request Mar 22, 2023
@idroz idroz mentioned this pull request Mar 29, 2023
@idroz
Copy link
Collaborator

idroz commented Mar 29, 2023

This works really well. What are your thoughts on disallowing special characters (e.g. non alphanumeric) in tag names.

For example, the following tag one, two is currently permitted, but is internally treated as a single entity, which might be confusing.

I can merge and add non-alphanumeric checks in a separate pull request.

@maxzinkus
Copy link
Collaborator Author

That's a really good idea. a-zA-Z0-9 and some separator characters (-, _, .) should be plenty.

@idroz idroz merged commit 2cbb0ca into beringresearch:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants