-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump cometbft #1851
Changes from 3 commits
6f4853f
88e2abf
e2862f9
103bd72
dff0e7d
6ced5ca
c13d323
8cf87c0
cdd29b6
b7a96fe
3308ff7
f1a1ab5
7879267
1dd63d8
8fe9880
0ec5891
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,14 +23,14 @@ require ( | |
github.com/berachain/beacon-kit/mod/log v0.0.0-20240705193247-d464364483df | ||
github.com/berachain/beacon-kit/mod/node-core v0.0.0-20240710023144-cd73de9f7378 | ||
github.com/berachain/beacon-kit/mod/primitives v0.0.0-20240726210727-594bfb4e7157 | ||
github.com/cometbft/cometbft v1.0.0-rc1.0.20240729121641-d06d2e8229ee | ||
github.com/cometbft/cometbft v1.0.0-rc1.0.20240806094948-2c4293ef36c4 | ||
github.com/cosmos/cosmos-sdk v0.51.0 | ||
github.com/ferranbt/fastssz v0.1.4-0.20240629094022-eac385e6ee79 | ||
github.com/spf13/afero v1.11.0 | ||
github.com/spf13/cobra v1.8.1 | ||
github.com/spf13/viper v1.19.0 | ||
github.com/stretchr/testify v1.9.0 | ||
golang.org/x/sync v0.7.0 | ||
golang.org/x/sync v0.8.0 | ||
) | ||
|
||
require ( | ||
|
@@ -90,7 +90,7 @@ require ( | |
github.com/cockroachdb/pebble v1.1.1 // indirect | ||
github.com/cockroachdb/redact v1.1.5 // indirect | ||
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06 // indirect | ||
github.com/cometbft/cometbft-db v0.12.0 // indirect | ||
github.com/cometbft/cometbft-db v0.13.0 // indirect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tip Codebase Verification Update Comment Reference to A reference to
Analysis chainVerify Removal of The dependency Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify no remaining references to `github.com/jmhodges/levigo`.
# Test: Search for any remaining references to the removed library.
rg --type go 'import "github.com/jmhodges/levigo"'
Length of output: 52 Script: #!/bin/bash
# Description: Verify no remaining references to `levigo` in the entire codebase.
# Test: Search for any remaining references to the removed library in Go files, comments, and documentation.
rg 'levigo'
Length of output: 81 |
||
github.com/cometbft/cometbft/api v1.0.0-rc.1.0.20240806094948-2c4293ef36c4 // indirect | ||
github.com/consensys/bavard v0.1.13 // indirect | ||
github.com/consensys/gnark-crypto v0.12.1 // indirect | ||
|
@@ -164,7 +164,6 @@ require ( | |
github.com/iancoleman/strcase v0.3.0 // indirect | ||
github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||
github.com/itsdevbear/comet-bls12-381 v0.0.0-20240413212931-2ae2f204cde7 // indirect | ||
github.com/jmhodges/levigo v1.0.0 // indirect | ||
github.com/klauspost/compress v1.17.9 // indirect | ||
github.com/klauspost/cpuid/v2 v2.2.8 // indirect | ||
github.com/kr/pretty v0.3.1 // indirect | ||
|
@@ -220,7 +219,6 @@ require ( | |
github.com/zondax/ledger-go v0.14.3 // indirect | ||
gitlab.com/yawning/secp256k1-voi v0.0.0-20230925100816-f2616030848b // indirect | ||
gitlab.com/yawning/tuplehash v0.0.0-20230713102510-df83abbf9a02 // indirect | ||
go.etcd.io/bbolt v1.4.0-alpha.1 // indirect | ||
go.opencensus.io v0.24.0 // indirect | ||
golang.org/x/crypto v0.25.0 // indirect | ||
golang.org/x/exp v0.0.0-20240613232115-7f521ea00fb8 // indirect | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ require ( | |
github.com/berachain/beacon-kit/mod/node-api v0.0.0-20240717210058-a144e074f6b2 | ||
github.com/berachain/beacon-kit/mod/payload v0.0.0-20240624003607-df94860f8eeb | ||
github.com/berachain/beacon-kit/mod/primitives v0.0.0-20240726210727-594bfb4e7157 | ||
github.com/cometbft/cometbft v1.0.0-rc1.0.20240729121641-d06d2e8229ee | ||
github.com/cometbft/cometbft v1.0.0-rc1.0.20240806094948-2c4293ef36c4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tip Codebase Verification Verify compatibility and stability of the updated The diff between the old and new versions of the Key changes include:
These changes may affect the stability and compatibility of your project. Please review the following files for potential impact:
Action required:
Analysis chainVerify compatibility and stability of the updated The version has been updated from Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify compatibility and stability of the updated `github.com/cometbft/cometbft` version.
# Test: Search for the usage of `github.com/cometbft/cometbft` in the codebase. Expect: No breaking changes.
rg --type go 'github.com/cometbft/cometbft'
Length of output: 2037 Script: #!/bin/bash
# Description: Extract and review the code sections where `github.com/cometbft/cometbft` is imported and used.
# List of files to check
files=(
"testing/e2e/suite/types/consensus_client.go"
"mod/consensus/pkg/cometbft/helpers.go"
"mod/consensus/pkg/cometbft/consensus.go"
"mod/storage/pkg/beacondb/index/validator.go"
"mod/runtime/pkg/middleware/middleware.go"
"mod/runtime/pkg/comet/consensus.go"
"mod/node-core/pkg/components/signer/signer.go"
"mod/node-core/pkg/app/export.go"
"mod/runtime/pkg/middleware/abci.go"
"mod/cli/pkg/config/server.go"
"mod/cli/pkg/config/comet.go"
"mod/cli/pkg/utils/context/server_context.go"
"mod/config/pkg/spec/testnet.go"
"mod/cli/pkg/builder/options.go"
"mod/cli/pkg/builder/types.go"
"mod/cli/pkg/builder/config.go"
"mod/cli/pkg/builder/builder.go"
"mod/cli/pkg/commands/cometbft/cometbft.go"
)
# Extract code sections with imports and their usage
for file in "${files[@]}"; do
echo "File: $file"
echo "Imports and usage:"
rg 'github.com/cometbft/cometbft' -A 5 "$file"
echo
done
Length of output: 8955 Script: #!/bin/bash
# Description: Compare the old and new versions of the `cometbft` dependency to identify any breaking changes or issues.
# Old and new versions of the dependency
old_version="v1.0.0-rc1.0.20240729121641-d06d2e8229ee"
new_version="v1.0.0-rc1.0.20240806094948-2c4293ef36c4"
# Files to check for changes
files=(
"rpc/client"
"rpc/client/http"
"abci/types"
"api/cometbft/abci/v1"
"crypto"
"api/cometbft/types/v1"
"types"
"privval"
"config"
"cmd/cometbft/commands"
)
# Function to compare old and new versions of a file
compare_versions() {
local file=$1
echo "Comparing $file"
git diff "$old_version" "$new_version" -- "$file"
echo
}
# Compare each file
for file in "${files[@]}"; do
compare_versions "$file"
done
Length of output: 3485 Script: #!/bin/bash
# Description: List all available versions/tags for the `cometbft` dependency and verify the existence of the specified versions.
# Repository URL for the `cometbft` dependency
repo_url="https://github.com/cometbft/cometbft"
# Clone the repository
git clone "$repo_url" cometbft_repo
# Change to the repository directory
cd cometbft_repo
# List all available tags
echo "Available tags:"
git tag
# Verify the existence of the specified versions
old_version="v1.0.0-rc1.0.20240729121641-d06d2e8229ee"
new_version="v1.0.0-rc1.0.20240806094948-2c4293ef36c4"
echo "Checking existence of old version ($old_version):"
git rev-parse "$old_version" >/dev/null 2>&1 && echo "Exists" || echo "Does not exist"
echo "Checking existence of new version ($new_version):"
git rev-parse "$new_version" >/dev/null 2>&1 && echo "Exists" || echo "Does not exist"
Length of output: 1375 Script: #!/bin/bash
# Description: Verify if the specified versions are commit hashes and compare the changes between these commits.
# Repository URL for the `cometbft` dependency
repo_url="https://github.com/cometbft/cometbft"
# Clone the repository
git clone "$repo_url" cometbft_repo
# Change to the repository directory
cd cometbft_repo
# Specified versions (likely commit hashes)
old_version="d06d2e8229ee"
new_version="2c4293ef36c4"
# Verify the existence of the specified commit hashes
echo "Checking existence of old version (commit hash: $old_version):"
git cat-file -t "$old_version" >/dev/null 2>&1 && echo "Exists" || echo "Does not exist"
echo "Checking existence of new version (commit hash: $new_version):"
git cat-file -t "$new_version" >/dev/null 2>&1 && echo "Exists" || echo "Does not exist"
# If both commits exist, compare the changes between these commits
if git cat-file -t "$old_version" >/dev/null 2>&1 && git cat-file -t "$new_version" >/dev/null 2>&1; then
echo "Comparing changes between $old_version and $new_version:"
git diff "$old_version" "$new_version"
else
echo "One or both commit hashes do not exist. Cannot compare changes."
fi
Length of output: 143460 |
||
github.com/mitchellh/mapstructure v1.5.0 | ||
github.com/spf13/viper v1.19.0 | ||
) | ||
|
@@ -43,7 +43,6 @@ require ( | |
github.com/cometbft/cometbft/api v1.0.0-rc.1.0.20240806094948-2c4293ef36c4 // indirect | ||
github.com/consensys/bavard v0.1.13 // indirect | ||
github.com/consensys/gnark-crypto v0.12.1 // indirect | ||
github.com/cosmos/crypto v0.1.2 // indirect | ||
github.com/cosmos/gogoproto v1.5.0 // indirect | ||
github.com/cpuguy83/go-md2man/v2 v2.0.4 // indirect | ||
github.com/crate-crypto/go-ipa v0.0.0-20240223125850-b1e8a79f509c // indirect | ||
|
@@ -124,7 +123,7 @@ require ( | |
golang.org/x/crypto v0.25.0 // indirect | ||
golang.org/x/exp v0.0.0-20240613232115-7f521ea00fb8 // indirect | ||
golang.org/x/net v0.27.0 // indirect | ||
golang.org/x/sync v0.7.0 // indirect | ||
golang.org/x/sync v0.8.0 // indirect | ||
golang.org/x/sys v0.22.0 // indirect | ||
golang.org/x/text v0.16.0 // indirect | ||
google.golang.org/genproto/googleapis/rpc v0.0.0-20240711142825-46eb208f015d // indirect | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
Update or remove the comment referring to
levigo
intesting/networks/80084/config.toml
.The reference to
levigo
in the comment is outdated since the dependency has been removed. Updating or removing this comment will help maintain clarity in the codebase.testing/networks/80084/config.toml
: Lines mentioningcleveldb (uses levigo wrapper)
Analysis chain
Verify the complete removal of
github.com/jmhodges/levigo
.Ensure that there are no remaining references to the removed dependency in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 41
Script:
Length of output: 81
Script:
Length of output: 436