fixing tests, removing unnecessary docs

benwtrent · Dec 6, 2024 · e8ade07 · e8ade07
1 parent 60bc4e9
commit e8ade07
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 155 deletions.
diff --git a/docs/changelog/118104.yaml b/docs/changelog/118104.yaml
@@ -6,7 +6,7 @@ issues: []
 breaking:
   title: Remove old `_knn_search` tech preview API in v9
   area: Vector Search
-  details: Please describe the details of this change for the release notes. You can
-    use asciidoc.
-  impact: Please describe the impact of this change to users
+  details: The original, tech-preview api for vector search, `_knn_search`, has been removed in v9. For all vector search
+    operations, you should utilize the `_search` endpoint.
+  impact: The `_knn_search` API is now inaccessible without providing a compatible-with flag for v8.
   notable: false
diff --git a/docs/reference/mapping/types/dense-vector.asciidoc b/docs/reference/mapping/types/dense-vector.asciidoc
@@ -232,8 +232,8 @@ it will be set to the length of the first vector added to the field.
 
 `index`::
 (Optional, Boolean)
-If `true`, you can search this field using the <<knn-search-api, kNN search
-API>>. Defaults to `true`.
+If `true`, you can search this field using the <<query-dsl-knn-query, knn query>>
+or <<search-api-knn, knn in _search>> . Defaults to `true`.
 
 [[dense-vector-similarity]]
 `similarity`::

diff --git a/docs/reference/search.asciidoc b/docs/reference/search.asciidoc
@@ -50,8 +50,6 @@ include::search/async-search.asciidoc[]
 
 include::search/point-in-time-api.asciidoc[]
 
-include::search/knn-search.asciidoc[]
-
 include::search/retriever.asciidoc[]
 
 include::search/rrf.asciidoc[]

diff --git a/docs/reference/search/knn-search.asciidoc b/docs/reference/search/knn-search.asciidoc
diff --git a/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/40_knn_search.yml b/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/40_knn_search.yml
@@ -215,7 +215,7 @@ setup:
 ---
 "kNN search in _knn_search endpoint":
   - skip:
-      features: [ "allowed_warnings" ]
+      features: [ "allowed_warnings", "headers" ]
   - do:
       headers:
         Content-Type: "application/vnd.elasticsearch+json;compatible-with=8"
@@ -243,7 +243,7 @@ setup:
   - requires:
       cluster_features: "gte_v8.2.0"
       reason: 'kNN with filtering added in 8.2'
-      test_runner_features: [ "allowed_warnings" ]
+      test_runner_features: [ "allowed_warnings", "headers" ]
   - do:
       headers:
         Content-Type: "application/vnd.elasticsearch+json;compatible-with=8"