Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add configuration option for flags #3

Merged
merged 4 commits into from
Oct 24, 2024
Merged

add configuration option for flags #3

merged 4 commits into from
Oct 24, 2024

Conversation

Kasi07
Copy link
Contributor

@Kasi07 Kasi07 commented Sep 3, 2024

As I have two accounts in my 1Password vault, I couldn't receive any secrets.
So I added a “flags” config to configure 1Password global flags.

benvp
benvp requested changes Sep 4, 2024
View reviewed changes
Copy link
Owner

@benvp benvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tahnks! Just a minor thing.

In addition, we should look into how this is possible when using #2 the one password sdk

src/app.ts Outdated Show resolved Hide resolved
@shadi-sharaf-nuk
Copy link

Thanks Kasi07! I was just going to PR the change myself and I'm happy to have checked the pull-requests first :D

Thanks @benvp for the quick review, would really love to have this change released!

@benvp benvp self-requested a review October 24, 2024 19:53
@benvp benvp merged commit 0c562fe into benvp:main Oct 24, 2024
@benvp
Copy link
Owner

benvp commented Oct 24, 2024

Sorry for the delay. Didn't have any time yet. Just released 0.2.0. And thanks for your contribs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benvp benvp benvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kasi07 @shadi-sharaf-nuk @benvp