Return proper Response object in Pages function

[benvinegar]

When converting to React Router 7, while trying to address some TypeScript typing issues, I made the mistake of not returning a proper Response object in the /collect Pages handler.

This meant that /collect was 1) writing the data, but 2) returning a 500 afterwards, which likely led to a host of issues like not setting If-Modified-Since headers properly (refs #148). This bug didn't appear in tests, nor using the Vite development server, which I mostly use for local development.

This highlights how the Pages function handlers need to be covered by tests, but on the flip side, they're being removed on the v3 branch underway.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.25%. Comparing base (7c28341) to head (b04f852).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/server/functions/collect.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   87.00%   87.25%   +0.25%     
==========================================
  Files          38       38              
  Lines        2439     2432       -7     
  Branches      302      302              
==========================================
  Hits         2122     2122              
+ Misses        309      302       -7     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.