fix: resolves wrong transformer args

bent10 · Nov 3, 2023 · a690bb1 · a690bb1
1 parent 752aaea
commit a690bb1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 14 deletions.
diff --git a/packages/code-preview/readme.md b/packages/code-preview/readme.md
@@ -157,7 +157,7 @@ Yields:
 
 ### `transformer?: Transformer`
 
-The transformer function for modifying code before replacing the `preview` placeholder.
+The transformer function for modifying preview code before replacing the `{preview}` placeholder.
 
 Default transformer:
 

diff --git a/packages/code-preview/src/transformer.ts b/packages/code-preview/src/transformer.ts
@@ -36,7 +36,7 @@ export function transform(token: Tokens.Generic, options: TransformOptions) {
   const dataInterpolation = {
     ...data,
     ...attrs,
-    preview: token.text
+    preview: transformer(token.text, attrs, data)
   }
 
   const acc: Array<Tokens.Code | Tokens.Generic | Tokens.HTML | Tokens.Space> =
@@ -46,16 +46,12 @@ export function transform(token: Tokens.Generic, options: TransformOptions) {
     if (type === 'placeholder') {
       acc.push(token)
     } else if (type === 'text') {
-      const interpolatedText = pupa(
-        normalizeCodeText(text),
-        dataInterpolation,
-        {
-          ignoreMissing: true
-        }
-      )
-      const transformedText = transformer(interpolatedText, attrs, data)
-
-      acc.push(createHtmlToken(interpolatedText, transformedText))
+      const normalizedText = normalizeCodeText(text)
+      const interpolatedText = pupa(normalizedText, dataInterpolation, {
+        ignoreMissing: true
+      })
+
+      acc.push(createHtmlToken(normalizedText, interpolatedText))
     }
   }
 

diff --git a/packages/code-preview/src/types.ts b/packages/code-preview/src/types.ts
@@ -10,8 +10,8 @@ export interface Options {
   template?: string
 
   /**
-   * The transformer function for modifying code before replacing the
-   * `preview` placeholder.
+   * The transformer function for modifying preview code before replacing the
+   * `{preview}` placeholder.
    *
    * @default (code) => code
    */