Make Doo work with Karma 6.x #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Karma command is supposed to be `karma start <config file>`. However, Doo has been generating `karma start <config file> <path to js>`. As far as I can tell, before version 6.0.0, Karma used to ignore the extra argument. Since version 6.0.0, it gives an error message and exits. This change drops the extra argument for Karma, which seems to fix the problem.
|
It seems that CircleCI integration has, once again, broken. Ah well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Karma command is supposed to be
karma start <config file>. However, Doo has been generatingkarma start <config file> <path to js>. As far as I can tell, before version 6.0.0, Karma used to ignore the extra argument. Since version 6.0.0, it gives an error message and exits.This change drops the extra argument for Karma, which seems to fix the problem.