Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for headless Firefox #160

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Conversation

korkeala
Copy link
Contributor

@korkeala korkeala commented Jan 2, 2018

The new version of https://github.com/karma-runner/karma-firefox-launcher (1.1.0) added support for launching firefox in headless mode. This pull-requests adds firefox-headless karma-env to start FirefoxHeadless plugin with lein doo.

You need Firefox >= 56 and karma-firefox-launcher >= 1.1.0 for testing.

@bensu
Copy link
Owner

bensu commented Jan 5, 2018

Thanks for the work!

  • Can you please add firefox-headless to the test suite?
  • Do you see any easy way to add a check for the karma version and warn if the required version is there?

@korkeala
Copy link
Contributor Author

korkeala commented Jan 7, 2018

I added it to the test suite and the tests failed, though looking at the log I suspect something else to be the cause.

I also added firefox-headless to CircleCI tests, but from what I've dug I don't think they have recent enough version of Firefox available (also the Chrome version is quite old, I wonder how the chrome-headless tests pass on CircleCI?).

Do you see any easy way to add a check for the karma version and warn if the required version is there?

No, sorry.

@miikka miikka mentioned this pull request Mar 3, 2018
6 tasks
@miikka miikka merged commit 0ad3fd7 into bensu:master Mar 9, 2018
@miikka
Copy link
Collaborator

miikka commented Mar 9, 2018

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants